D13271: Check that Session* isn't a nullptr

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> hindenburg wrote in TerminalDisplay.cpp:798
> This is not quite the same - the previous checks _sessionController is not nullptr; this new doesn't.

Reflecting on this diff and the other one (about primaryScreen), if the session is null, checking for null won't really make a difference as the process is pretty much screwed with a TerminalDisplay but no associated SessionController or Session.

It makes more sense to add a Q_ASSERT() to catch this in debug builds; WDYT?

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D13271

To: ahmadsamir, #konsole
Cc: hindenburg, konsole-devel, #konsole, herrold, ngraham, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180602/6118f123/attachment-0001.html>