D13271: Check that Session* isn't a nullptr

Kurt Hindenburg noreply at phabricator.kde.org
Sat Jun 2 03:07:11 UTC 2018


hindenburg added inline comments.

INLINE COMMENTS

> TerminalDisplay.cpp:798
>  {
> -    if (sessionController() != nullptr) {
> -        Profile::Ptr currentProfile = SessionManager::instance()->sessionProfile(sessionController()->session());
> +    Session *currentSession = _sessionController->session();
> +

This is not quite the same - the previous checks _sessionController is not nullptr; this new doesn't.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D13271

To: ahmadsamir, #konsole
Cc: hindenburg, konsole-devel, #konsole, herrold, ngraham, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180602/2a391876/attachment.html>


More information about the konsole-devel mailing list