D13271: Check that Session* isn't a nullptr

Kurt Hindenburg noreply at phabricator.kde.org
Tue Jun 5 12:17:47 UTC 2018


hindenburg added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in TerminalDisplay.cpp:798
> Reflecting on this diff and the other one (about primaryScreen), if the session is null, checking for null won't really make a difference as the process is pretty much screwed with a TerminalDisplay but no associated SessionController or Session.
> 
> It makes more sense to add a Q_ASSERT() to catch this in debug builds; WDYT?

Ok that is fine

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D13271

To: ahmadsamir, #konsole
Cc: hindenburg, konsole-devel, #konsole, herrold, ngraham, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180605/473e1550/attachment.html>


More information about the konsole-devel mailing list