[Konsole-devel] Review Request 127625: Port away from kdelibs4support

[Martin Tobias Holmedahl Sandsmark]

> On June 8, 2016, 6:22 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > ping?
> 
> Kurt Hindenburg wrote:
>     If you're comfortable that we can fix any issues in the few months before the next release, go ahead and commmit.  This needs to go in sometime.
>     
>     For some commands (--list-profiles, list-profile-properties), I see this at the end
>     [22::18:35.854] kdemain: konsoleApp::init failed

I've been using this for months now, with no issues except the one mentioned in the other bug. That doesn't seem related to this, it seems to be some weird bug with the shared data pointers or something, and happened after konsole had been running for a week with several upgrades of the libraries it was using.

The debug output was misleading, the 0 return value from Application::init is expected when the user passes an argument that should lead to exiting. I have fixed it.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127625/#review96300
-----------------------------------------------------------


On May 14, 2016, 2:21 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127625/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 2:21 p.m.)
> 
> 
> Review request for Konsole, Kai Uwe Broulik, David Faure, and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Continuation of https://git.reviewboard.kde.org/r/126808/ 
> 
> Pretty much all of this is done by D?vis Mos?ns in that review, I just fixed some of the issues with it:
> 
>  * The names of the command line arguments.
>  * Warning about empty argument lists when opening a new window in an existing instance.
>  * An unimportant crash when opening a new window in an existing instance (it was happening on exit).
>  * Creation/adding of the actions for the standalone Konsole application.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 273214c 
>   src/Application.h b7389ef 
>   src/Application.cpp 326c766 
>   src/CMakeLists.txt 6798079 
>   src/MainWindow.h 500b395 
>   src/MainWindow.cpp d2143b8 
>   src/SessionController.h 02f51d9 
>   src/SessionController.cpp 27f9e9f 
>   src/SessionListModel.cpp fb28bb8 
>   src/autotests/PartTest.cpp b3e7797 
>   src/main.cpp 5e1420e 
>   src/settings/ProfileSettings.cpp d6dafbf 
> 
> Diff: https://git.reviewboard.kde.org/r/127625/diff/
> 
> 
> Testing
> -------
> 
> I have tried to trigger edge cases, and I've been using this daily for over a month.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160611/ca123240/attachment.html>