[Konsole-devel] Review Request 127625: Port away from kdelibs4support

Martin Tobias Holmedahl Sandsmark martin.sandsmark at kde.org
Sat Jun 11 15:28:35 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated June 11, 2016, 6:28 p.m.)


This change has been marked as submitted.

Review request for Konsole, Kai Uwe Broulik, David Faure, and Kurt Hindenburg.


Submitted with commit 27dec8d02f705c77eef45a2533bed203eec9454f by Martin T. H. Sandsmark to branch master.

Repository: konsole


Continuation of https://git.reviewboard.kde.org/r/126808/ 

Pretty much all of this is done by D?vis Mos?ns in that review, I just fixed some of the issues with it:

 * The names of the command line arguments.
 * Warning about empty argument lists when opening a new window in an existing instance.
 * An unimportant crash when opening a new window in an existing instance (it was happening on exit).
 * Creation/adding of the actions for the standalone Konsole application.


  CMakeLists.txt 273214c 
  src/Application.h b7389ef 
  src/Application.cpp 326c766 
  src/CMakeLists.txt 6798079 
  src/MainWindow.h 500b395 
  src/MainWindow.cpp d2143b8 
  src/SessionController.h 02f51d9 
  src/SessionController.cpp 27f9e9f 
  src/SessionListModel.cpp fb28bb8 
  src/autotests/PartTest.cpp b3e7797 
  src/main.cpp 5e1420e 
  src/settings/ProfileSettings.cpp d6dafbf 

Diff: https://git.reviewboard.kde.org/r/127625/diff/


I have tried to trigger edge cases, and I've been using this daily for over a month.


Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160611/23fa58ab/attachment-0001.html>

More information about the konsole-devel mailing list