<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127625/">https://git.reviewboard.kde.org/r/127625/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 8th, 2016, 6:22 p.m. UTC, <b>Martin Tobias Holmedahl Sandsmark</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ping?</p></pre>
</blockquote>
<p>On June 11th, 2016, 2:19 a.m. UTC, <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If you're comfortable that we can fix any issues in the few months before the next release, go ahead and commmit. This needs to go in sometime.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For some commands (--list-profiles, list-profile-properties), I see this at the end
[22::18:35.854] kdemain: konsoleApp::init failed</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've been using this for months now, with no issues except the one mentioned in the other bug. That doesn't seem related to this, it seems to be some weird bug with the shared data pointers or something, and happened after konsole had been running for a week with several upgrades of the libraries it was using.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The debug output was misleading, the 0 return value from Application::init is expected when the user passes an argument that should lead to exiting. I have fixed it.</p></pre>
<br />
<p>- Martin Tobias Holmedahl</p>
<br />
<p>On May 14th, 2016, 2:21 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Konsole, Kai Uwe Broulik, David Faure, and Kurt Hindenburg.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>
<p style="color: grey;"><i>Updated May 14, 2016, 2:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Continuation of https://git.reviewboard.kde.org/r/126808/ </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Pretty much all of this is done by D?vis Mos?ns in that review, I just fixed some of the issues with it:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The names of the command line arguments.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Warning about empty argument lists when opening a new window in an existing instance.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">An unimportant crash when opening a new window in an existing instance (it was happening on exit).</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Creation/adding of the actions for the standalone Konsole application.</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have tried to trigger edge cases, and I've been using this daily for over a month.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(273214c)</span></li>
<li>src/Application.h <span style="color: grey">(b7389ef)</span></li>
<li>src/Application.cpp <span style="color: grey">(326c766)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(6798079)</span></li>
<li>src/MainWindow.h <span style="color: grey">(500b395)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(d2143b8)</span></li>
<li>src/SessionController.h <span style="color: grey">(02f51d9)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(27f9e9f)</span></li>
<li>src/SessionListModel.cpp <span style="color: grey">(fb28bb8)</span></li>
<li>src/autotests/PartTest.cpp <span style="color: grey">(b3e7797)</span></li>
<li>src/main.cpp <span style="color: grey">(5e1420e)</span></li>
<li>src/settings/ProfileSettings.cpp <span style="color: grey">(d6dafbf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127625/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>