[Konsole-devel] Review Request 124739: Set tabs movable again

[Kurt Hindenburg]

> On Aug 17, 2015, at 11:51 AM, Luigi Toscano <luigi.toscano at tiscali.it> wrote:
> 
> This is an automatically generated e-mail. To reply, visit:https://git.reviewboard.kde.org/r/124739/ <https://git.reviewboard.kde.org/r/124739/>
> On August 17th, 2015, 2:25 a.m. CEST, Kurt Hindenburg wrote:
> 
> Whoa nice job!  This fixes moving of tabs and also dragging a tab outside its window to create another window.  Thanks a lot.
> On August 17th, 2015, 10:56 a.m. CEST, David Edmundson wrote:
> 
> to 15.08 too?
> On August 17th, 2015, 3:18 p.m. CEST, Kurt Hindenburg wrote:
> 
> we missed the cutof for 15.08 by a couple of weeks
> But this is a bugfix, and without strings, so as maintainer you can decide to push it to Applications/15.08 (which I would do, otherwise people would get it only in December).
> 
Well 15.08 has already been tagged and I think adding protected members breaks BIC - I’ll see about 15.08.1

https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B <https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++>

Kurt
> - Luigi
> 
> 
> On August 17th, 2015, 3:16 p.m. CEST, David Edmundson wrote:
> 
> Review request for Konsole.
> By David Edmundson.
> Updated Aug. 17, 2015, 3:16 p.m.
> 
> Repository: konsole
> Description
> 
> KTabBar used to do internal drag & drop re-ordering
> Konsole massively expanded on this to do cross window drag & drop.
> 
> Now Qt does tabbar reordering, but Konsole relied on KTabBar's signals
> to say when a drag start before overriding the rest.
> 
> To solve this I've added the same drag start signal manually into
> Konsole's tab bar.
> 
> BUG: 348057
> Diffs
> 
> src/ViewContainer.cpp (02be309fbd22cf52ea963bbd11c0e589b1e5004a)
> src/ViewContainerTabBar.h (0e2985fd53021edbc9f5fb58aeadd40c564728bf)
> src/ViewContainerTabBar.cpp (399c391d619d23b34bb03be9f61417931f80ee51)
> View Diff <https://git.reviewboard.kde.org/r/124739/diff/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150817/2584fbcc/attachment.html>