[Konsole-devel] Review Request 124739: Set tabs movable again

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124739/
-----------------------------------------------------------

(Updated Aug. 17, 2015, 1:16 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole.


Changes
-------

Submitted with commit a9bac171f77982c6c20a437bc94b43e8ef863a87 by Kurt Hindenburg to branch master.


Repository: konsole


Description
-------

KTabBar used to do internal drag & drop re-ordering
Konsole massively expanded on this to do cross window drag & drop.

Now Qt does tabbar reordering, but Konsole relied on KTabBar's signals
to say when a drag start before overriding the rest.

To solve this I've added the same drag start signal manually into
Konsole's tab bar.

BUG: 348057


Diffs
-----

  src/ViewContainer.cpp 02be309fbd22cf52ea963bbd11c0e589b1e5004a 
  src/ViewContainerTabBar.h 0e2985fd53021edbc9f5fb58aeadd40c564728bf 
  src/ViewContainerTabBar.cpp 399c391d619d23b34bb03be9f61417931f80ee51 

Diff: https://git.reviewboard.kde.org/r/124739/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150817/3dba4528/attachment.html>