<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 17, 2015, at 11:51 AM, Luigi Toscano <<a href="mailto:luigi.toscano@tiscali.it" class="">luigi.toscano@tiscali.it</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<div class="">
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;" class="">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;" class="">
<tbody class=""><tr class="">
<td class="">
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124739/" class="">https://git.reviewboard.kde.org/r/124739/</a>
</td>
</tr>
</tbody></table>
<br class="">
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;" class=""><p style="margin-top: 0;" class="">On August 17th, 2015, 2:25 a.m. CEST, <b class="">Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;" class="">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;" class=""><div style="padding: 0px; text-rendering: inherit; margin: 0px; line-height: inherit; white-space: inherit;" class="">Whoa nice job! This fixes moving of tabs and also dragging a tab outside its window to create another window. Thanks a lot.</div></pre>
</blockquote><p class="">On August 17th, 2015, 10:56 a.m. CEST, <b class="">David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;" class="">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;" class=""><div style="padding: 0px; text-rendering: inherit; margin: 0px; line-height: inherit; white-space: inherit;" class="">to 15.08 too?</div></pre>
</blockquote><p class="">On August 17th, 2015, 3:18 p.m. CEST, <b class="">Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;" class="">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;" class=""><div style="padding: 0px; text-rendering: inherit; margin: 0px; line-height: inherit; white-space: inherit;" class="">we missed the cutof for 15.08 by a couple of weeks</div></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;" class=""><div style="padding: 0px; text-rendering: inherit; margin: 0px; line-height: inherit; white-space: inherit;" class="">But this is a bugfix, and without strings, so as maintainer you can decide to push it to Applications/15.08 (which I would do, otherwise people would get it only in December).</div></pre>
<br class=""></div></div></div></blockquote>Well 15.08 has already been tagged and I think adding protected members breaks BIC - I’ll see about 15.08.1</div><div><br class=""></div><div><a href="https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++" class="">https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B</a></div><div><br class=""></div><div>Kurt<br class=""><blockquote type="cite" class=""><div class=""><div class=""><div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;" class=""><p class="">- Luigi</p>
<br class=""><p class="">On August 17th, 2015, 3:16 p.m. CEST, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;" class="">
<tbody class=""><tr class="">
<td class="">
<div class="">Review request for Konsole.</div>
<div class="">By David Edmundson.</div><p style="color: grey;" class=""><i class="">Updated Aug. 17, 2015, 3:16 p.m.</i></p>
<div style="margin-top: 1.5em;" class="">
<b style="color: #575012; font-size: 10pt;" class="">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;" class="">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0" class="">
<tbody class=""><tr class="">
<td class="">
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;" class="">KTabBar used to do internal drag & drop re-ordering
Konsole massively expanded on this to do cross window drag & drop.
Now Qt does tabbar reordering, but Konsole relied on KTabBar's signals
to say when a drag start before overriding the rest.
To solve this I've added the same drag start signal manually into
Konsole's tab bar.
BUG: 348057</pre>
</td>
</tr>
</tbody></table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;" class="">Diffs </h1>
<ul style="margin-left: 3em; padding-left: 0;" class="">
<li class="">src/ViewContainer.cpp <span style="color: grey" class="">(02be309fbd22cf52ea963bbd11c0e589b1e5004a)</span></li>
<li class="">src/ViewContainerTabBar.h <span style="color: grey" class="">(0e2985fd53021edbc9f5fb58aeadd40c564728bf)</span></li>
<li class="">src/ViewContainerTabBar.cpp <span style="color: grey" class="">(399c391d619d23b34bb03be9f61417931f80ee51)</span></li>
</ul><p class=""><a href="https://git.reviewboard.kde.org/r/124739/diff/" style="margin-left: 3em;" class="">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div>
</div>
</div></blockquote></div><br class=""></body></html>