[Konsole-devel] Review Request 119909: Version the konsoleprivate library

[Hrvoje Senjan]

> On Sept. 13, 2014, 5:53 p.m., Sune Vuorela wrote:
> > I think the concept is a elegant hack, but having the .so.X and so.X.Y.Z files having different X values is just wrong and broken. They must match.
> > 
> > Though I think it would be cleaner to rename libkonsoleprivate to libkonsole5private or similar.

might be true. i just wanted to avoid both kdelibs4 and KF5 variants to install $libdir/libkonsoleprivate.so


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119909/#review66412
-----------------------------------------------------------


On Aug. 22, 2014, 11:31 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119909/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2014, 11:31 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> This allows (on packaging level at least) co-existence of kdelibs4 & KF5 konsole-part
> 
> 
> Diffs
> -----
> 
>   src/main.cpp 955e028 
>   CMakeLists.txt 9bc3c5c 
>   src/CMakeLists.txt 551a148 
>   src/config-konsole.h.cmake 2860d68 
> 
> Diff: https://git.reviewboard.kde.org/r/119909/diff/
> 
> 
> Testing
> -------
> 
> Builds
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20140913/4dff327c/attachment.html>