[Konsole-devel] Review Request 119909: Version the konsoleprivate library

[Sune Vuorela]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119909/#review66412
-----------------------------------------------------------


I think the concept is a elegant hack, but having the .so.X and so.X.Y.Z files having different X values is just wrong and broken. They must match.

Though I think it would be cleaner to rename libkonsoleprivate to libkonsole5private or similar.


CMakeLists.txt
<https://git.reviewboard.kde.org/r/119909/#comment46320>

    This gives install components like:
    -- Installing: /home/kurthindenburg/kf5/kde_frameworks/lib/i386-linux-gnu/libkonsoleprivate.so.2.99.900



CMakeLists.txt
<https://git.reviewboard.kde.org/r/119909/#comment46321>

    This gives install paths like 
    -- Installing: /home/kurthindenburg/kf5/kde_frameworks/lib/i386-linux-gnu/libkonsoleprivate.so.5


- Sune Vuorela


On Aug. 22, 2014, 9:31 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119909/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2014, 9:31 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> This allows (on packaging level at least) co-existence of kdelibs4 & KF5 konsole-part
> 
> 
> Diffs
> -----
> 
>   src/main.cpp 955e028 
>   CMakeLists.txt 9bc3c5c 
>   src/CMakeLists.txt 551a148 
>   src/config-konsole.h.cmake 2860d68 
> 
> Diff: https://git.reviewboard.kde.org/r/119909/diff/
> 
> 
> Testing
> -------
> 
> Builds
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20140913/86cf30fa/attachment-0001.html>