[Konsole-devel] Review Request 119909: Version the konsoleprivate library

[Hrvoje Senjan]

> On Sept. 13, 2014, 5:53 p.m., Sune Vuorela wrote:
> > CMakeLists.txt, line 25
> > <https://git.reviewboard.kde.org/r/119909/diff/1/?file=307159#file307159line25>
> >
> >     This gives install paths like 
> >     -- Installing: /home/kurthindenburg/kf5/kde_frameworks/lib/i386-linux-gnu/libkonsoleprivate.so.5

soversion was more-less randomly chosen, as 'everything' spins around 5 these days ;-). since the version indicates it's going towards 3, i can change it either 2 or 3, whatever is prefered...


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119909/#review66412
-----------------------------------------------------------


On Aug. 22, 2014, 11:31 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119909/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2014, 11:31 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> This allows (on packaging level at least) co-existence of kdelibs4 & KF5 konsole-part
> 
> 
> Diffs
> -----
> 
>   src/main.cpp 955e028 
>   CMakeLists.txt 9bc3c5c 
>   src/CMakeLists.txt 551a148 
>   src/config-konsole.h.cmake 2860d68 
> 
> Diff: https://git.reviewboard.kde.org/r/119909/diff/
> 
> 
> Testing
> -------
> 
> Builds
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20140913/213e4a1d/attachment.html>