[Konsole-devel] Review Request: The "Copy Input To" submenu should use combo boxes instead of check boxes

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104202/#review11253
-----------------------------------------------------------

Ship it!


UI looks fine

The only thing that stood out was:
_copyToAllTabsAction = copyInputToAllTabsAction;
I see where we use it later; perhaps use the _copy instead of the copy?  and/or add comment.

- Kurt Hindenburg


On March 9, 2012, 5:02 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104202/
> -----------------------------------------------------------
> 
> (Updated March 9, 2012, 5:02 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> The existing UI is misleading: the three check boxes imply that you can enable any of them independently, but actually you can only enable one of them at any time. So the three choices should be shown using combo boxes instead of check boxes.
> 
> The code is basically stolen from dolphin. Again, I'm always not that confident with UI changes, so please check the code for any stupid or unnecessary code.
> 
> 
> Diffs
> -----
> 
>   desktop/sessionui.rc 0dd1b66 
>   src/SessionController.h 46714c0 
>   src/SessionController.cpp f437d9b 
> 
> Diff: http://git.reviewboard.kde.org/r/104202/diff/
> 
> 
> Testing
> -------
> 
> Seems fine.
> 
> 
> Screenshots
> -----------
> 
> before
>   http://git.reviewboard.kde.org/r/104202/s/454/
> after
>   http://git.reviewboard.kde.org/r/104202/s/455/
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120309/ebbf739c/attachment.html>