<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104202/">http://git.reviewboard.kde.org/r/104202/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">UI looks fine
The only thing that stood out was:
_copyToAllTabsAction = copyInputToAllTabsAction;
I see where we use it later; perhaps use the _copy instead of the copy? and/or add comment.</pre>
<br />
<p>- Kurt</p>
<br />
<p>On March 9th, 2012, 5:02 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated March 9, 2012, 5:02 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The existing UI is misleading: the three check boxes imply that you can enable any of them independently, but actually you can only enable one of them at any time. So the three choices should be shown using combo boxes instead of check boxes.
The code is basically stolen from dolphin. Again, I'm always not that confident with UI changes, so please check the code for any stupid or unnecessary code.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktop/sessionui.rc <span style="color: grey">(0dd1b66)</span></li>
<li>src/SessionController.h <span style="color: grey">(46714c0)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(f437d9b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104202/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104202/s/454/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/09/before_400x100.png" style="border: 1px black solid;" alt="before" /></a>
<a href="http://git.reviewboard.kde.org/r/104202/s/455/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/09/after_400x100.png" style="border: 1px black solid;" alt="after" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>