[Konsole-devel] Review Request: The "Copy Input To" submenu should use combo boxes instead of check boxes

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104202/
-----------------------------------------------------------

Review request for Konsole.


Description
-------

The existing UI is misleading: the three check boxes imply that you can enable any of them independently, but actually you can only enable one of them at any time. So the three choices should be shown using combo boxes instead of check boxes.

The code is basically stolen from dolphin. Again, I'm always not that confident with UI changes, so please check the code for any stupid or unnecessary code.


Diffs
-----

  desktop/sessionui.rc 0dd1b66 
  src/SessionController.h 46714c0 
  src/SessionController.cpp f437d9b 

Diff: http://git.reviewboard.kde.org/r/104202/diff/


Testing
-------

Seems fine.


Screenshots
-----------

before
  http://git.reviewboard.kde.org/r/104202/s/454/
after
  http://git.reviewboard.kde.org/r/104202/s/455/


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120309/d88f8ff2/attachment.html>