[Konsole-devel] Review Request: Finer grained choices for X Selection/Clipboard

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103861/#review12894
-----------------------------------------------------------


OK, I have look at the patch in more detail. 

Some change is unacceptable. For example, simply renaming "Interaction Options" group to "Mouse Options" group is not a good idea(although the latter might feel more clear), because that would "reset" users' existing settings.

Some change is questionable. For example, the logic for copying is moved from TerminalDisplay into SessioController, while the logic for (middle) pasting remains in TerminalDisplay. I prefer keeping them in the same place .

In general, the current patch is not suitable for committing. I have made another patch(both features included) based upon this one, and will commit it sometime later.


- Jekyll Wu


On April 22, 2012, 2:12 p.m., Adam Batkin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103861/
> -----------------------------------------------------------
> 
> (Updated April 22, 2012, 2:12 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> * Creates new "Mouse" Profile Options tab with all of the mouse stuff
> * Selected text can now go to X Selection AND Clipboard (instead of ONLY X Selection)
> * Middle-Mouse clicks can paste from X Selection or Profile
> 
> The whole rationale here is that I almost never care about the X Selection (and
> I'm probably not alone). And in the few cases where I DO care, well, that's my
> problem. So this patch leaves all of the defaults as-is (no one will notice a
> change) but for people for whom it makes a difference, now they can control
> what is going on.
> 
> 
> This addresses bug 183490.
>     http://bugs.kde.org/show_bug.cgi?id=183490
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h c330fc6 
>   src/EditProfileDialog.cpp 1c0a462 
>   src/EditProfileDialog.ui 707c20a 
>   src/Profile.h 78e95cf 
>   src/Profile.cpp 198640e 
>   src/SessionController.h 85dbdbb 
>   src/SessionController.cpp 0404f1f 
>   src/TerminalDisplay.cpp 195942b 
> 
> Diff: http://git.reviewboard.kde.org/r/103861/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Mouse tab
>   http://git.reviewboard.kde.org/r/103861/s/543/
> 
> 
> Thanks,
> 
> Adam Batkin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120425/b25294b7/attachment.html>