[Konsole-devel] Review Request: Finer grained choices for X Selection/Clipboard

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103861/#review12895
-----------------------------------------------------------


This review has been submitted with commit bb818010b42a3d6fcdc4a057f0afd2e7b7a85b9f by Jekyll Wu to branch master.

- Commit Hook


On April 22, 2012, 2:12 p.m., Adam Batkin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103861/
> -----------------------------------------------------------
> 
> (Updated April 22, 2012, 2:12 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> * Creates new "Mouse" Profile Options tab with all of the mouse stuff
> * Selected text can now go to X Selection AND Clipboard (instead of ONLY X Selection)
> * Middle-Mouse clicks can paste from X Selection or Profile
> 
> The whole rationale here is that I almost never care about the X Selection (and
> I'm probably not alone). And in the few cases where I DO care, well, that's my
> problem. So this patch leaves all of the defaults as-is (no one will notice a
> change) but for people for whom it makes a difference, now they can control
> what is going on.
> 
> 
> This addresses bug 183490.
>     http://bugs.kde.org/show_bug.cgi?id=183490
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h c330fc6 
>   src/EditProfileDialog.cpp 1c0a462 
>   src/EditProfileDialog.ui 707c20a 
>   src/Profile.h 78e95cf 
>   src/Profile.cpp 198640e 
>   src/SessionController.h 85dbdbb 
>   src/SessionController.cpp 0404f1f 
>   src/TerminalDisplay.cpp 195942b 
> 
> Diff: http://git.reviewboard.kde.org/r/103861/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Mouse tab
>   http://git.reviewboard.kde.org/r/103861/s/543/
> 
> 
> Thanks,
> 
> Adam Batkin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120425/c0718f57/attachment.html>