<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103861/">http://git.reviewboard.kde.org/r/103861/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, I have look at the patch in more detail.
Some change is unacceptable. For example, simply renaming "Interaction Options" group to "Mouse Options" group is not a good idea(although the latter might feel more clear), because that would "reset" users' existing settings.
Some change is questionable. For example, the logic for copying is moved from TerminalDisplay into SessioController, while the logic for (middle) pasting remains in TerminalDisplay. I prefer keeping them in the same place .
In general, the current patch is not suitable for committing. I have made another patch(both features included) based upon this one, and will commit it sometime later.
</pre>
<br />
<p>- Jekyll</p>
<br />
<p>On April 22nd, 2012, 2:12 p.m., Adam Batkin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Adam Batkin.</div>
<p style="color: grey;"><i>Updated April 22, 2012, 2:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Creates new "Mouse" Profile Options tab with all of the mouse stuff
* Selected text can now go to X Selection AND Clipboard (instead of ONLY X Selection)
* Middle-Mouse clicks can paste from X Selection or Profile
The whole rationale here is that I almost never care about the X Selection (and
I'm probably not alone). And in the few cases where I DO care, well, that's my
problem. So this patch leaves all of the defaults as-is (no one will notice a
change) but for people for whom it makes a difference, now they can control
what is going on.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=183490">183490</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EditProfileDialog.h <span style="color: grey">(c330fc6)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(1c0a462)</span></li>
<li>src/EditProfileDialog.ui <span style="color: grey">(707c20a)</span></li>
<li>src/Profile.h <span style="color: grey">(78e95cf)</span></li>
<li>src/Profile.cpp <span style="color: grey">(198640e)</span></li>
<li>src/SessionController.h <span style="color: grey">(85dbdbb)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(0404f1f)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(195942b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103861/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103861/s/543/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/22/mouse-tab_400x100.png" style="border: 1px black solid;" alt="Mouse tab" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>