[Konsole-devel] Review Request: use a static _sessionRuntimeProfiles to store runtime profiles

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102506/#review6222
-----------------------------------------------------------


This review has been submitted with commit a5eaba7f76dc5a0b97b2e800997cb2952b2d758f by Jekyll Wu to branch master.

- Commit


On Sept. 1, 2011, 4:09 p.m., Gu Rui wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102506/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2011, 4:09 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> This commit eliminates the useless new Profile in SessionManager::sessionProfileCommandReceived. If user use tips in http://vim.wikia.com/wiki/Change_cursor_shape_in_different_modes , it will create a lot of Profiles.
> 
> 
> Diffs
> -----
> 
>   src/SessionManager.cpp 028b76f8e3a0cdb5b2e4a014bdf89ca6ac9f2d39 
> 
> Diff: http://git.reviewboard.kde.org/r/102506/diff
> 
> 
> Testing
> -------
> 
> I added debug output in Profile constructors. Each session will create only one runtime Profile.
> 
> 
> Thanks,
> 
> Gu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110902/c4b15b36/attachment.html>