[Konsole-devel] Review Request: use a static _sessionRuntimeProfiles to store runtime profiles

Gu Rui chaos.proton at gmail.com
Thu Sep 1 16:09:45 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102506/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

This commit eliminates the useless new Profile in SessionManager::sessionProfileCommandReceived. If user use tips in http://vim.wikia.com/wiki/Change_cursor_shape_in_different_modes , it will create a lot of Profiles.


Diffs
-----

  src/SessionManager.cpp 028b76f8e3a0cdb5b2e4a014bdf89ca6ac9f2d39 

Diff: http://git.reviewboard.kde.org/r/102506/diff


Testing
-------

I added debug output in Profile constructors. Each session will create only one runtime Profile.


Thanks,

Gu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110901/a570b93f/attachment.html>


More information about the konsole-devel mailing list