[Konsole-devel] Review Request: remove Profile in _sessionProfiles and _sessionRuntimeProfiles when the session is closed

[Gu Rui]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102507/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

After a session is closed, the associated Profile don't got removed from _sessionProfiles and _sessionRuntimeProfiles. This may lead to memory leaks. Since Profile::Ptr is a KsharedPtr, it's safe to deref is here.


Diffs
-----

  src/SessionManager.h d89ab909c2c3ff3719289d3e45b056ad92b6a685 
  src/SessionManager.cpp 028b76f8e3a0cdb5b2e4a014bdf89ca6ac9f2d39 

Diff: http://git.reviewboard.kde.org/r/102507/diff


Testing
-------

Tested on my box with debug code in Profile's destructor. Seems fine.


Thanks,

Gu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110901/432895d4/attachment.html>