[Konsole-devel] Review Request: remove Profile in _sessionProfiles and _sessionRuntimeProfiles when the session is closed

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102507/#review6223
-----------------------------------------------------------


This review has been submitted with commit afea863b2a54eb0f2de017e7fb083bafb706c28e by Jekyll Wu to branch master.

- Commit


On Sept. 1, 2011, 4:22 p.m., Gu Rui wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102507/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2011, 4:22 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> After a session is closed, the associated Profile don't got removed from _sessionProfiles and _sessionRuntimeProfiles. This may lead to memory leaks. Since Profile::Ptr is a KsharedPtr, it's safe to deref is here.
> 
> 
> Diffs
> -----
> 
>   src/SessionManager.h d89ab909c2c3ff3719289d3e45b056ad92b6a685 
>   src/SessionManager.cpp 028b76f8e3a0cdb5b2e4a014bdf89ca6ac9f2d39 
> 
> Diff: http://git.reviewboard.kde.org/r/102507/diff
> 
> 
> Testing
> -------
> 
> Tested on my box with debug code in Profile's destructor. Seems fine.
> 
> 
> Thanks,
> 
> Gu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110902/b98b44d7/attachment.html>