[Konsole-devel] Review Request: Patch to add ZModem Upload and Download

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1095/#review2175
-----------------------------------------------------------

Ship it!


I've committed this to trunk with minor changes (removed the whitespace and commented out code).

- Kurt


On 2009-08-28 16:22:00, Thomas Dreibholz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1095/
> -----------------------------------------------------------
> 
> (Updated 2009-08-28 16:22:00)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> This patch adds support for Z-modem upload and download to konsole (as it has been available for KDE <4.0).
> 
> 
> This addresses bug 200744.
>     https://bugs.kde.org/show_bug.cgi?id=200744
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konsole/desktop/sessionui.rc 1016687 
>   /trunk/KDE/kdebase/apps/konsole/src/Session.cpp 1016687 
>   /trunk/KDE/kdebase/apps/konsole/src/SessionController.h 1016687 
>   /trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 1016687 
>   /trunk/KDE/kdebase/apps/konsole/src/ZModemDialog.cpp 1016687 
>   /trunk/KDE/kdebase/apps/konsole/src/main.cpp 1016687 
> 
> Diff: http://reviewboard.kde.org/r/1095/diff
> 
> 
> Testing
> -------
> 
> Tested against SVN revision 1016709. Used Valgrind to check for problems -> no problems found.
> 
> 
> Thanks,
> 
> Thomas
> 
>