[Konsole-devel] Review Request: Patch to add ZModem Upload and Download

Thomas Dreibholz dreibh at iem.uni-due.de
Fri Aug 28 16:22:00 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1095/
-----------------------------------------------------------

(Updated 2009-08-28 16:22:00.067319)


Review request for Konsole.


Summary
-------

This patch adds support for Z-modem upload and download to konsole (as it has been available for KDE <4.0).


This addresses bug 200744.
    https://bugs.kde.org/show_bug.cgi?id=200744


Diffs
-----

  /trunk/KDE/kdebase/apps/konsole/desktop/sessionui.rc 1016687 
  /trunk/KDE/kdebase/apps/konsole/src/Session.cpp 1016687 
  /trunk/KDE/kdebase/apps/konsole/src/SessionController.h 1016687 
  /trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 1016687 
  /trunk/KDE/kdebase/apps/konsole/src/ZModemDialog.cpp 1016687 
  /trunk/KDE/kdebase/apps/konsole/src/main.cpp 1016687 

Diff: http://reviewboard.kde.org/r/1095/diff


Testing (updated)
-------

Tested against SVN revision 1016709. Used Valgrind to check for problems -> no problems found.


Thanks,

Thomas




More information about the konsole-devel mailing list