[Konsole-devel] Review Request: Patch for better visualization of session's master mode status

[Thomas Dreibholz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1058/
-----------------------------------------------------------

(Updated 2009-08-03 14:18:39.831428)


Review request for Konsole.


Summary
-------

konsole only indicates the master mode ("Copy Input To ...") by a small asterisk ('*'). This can be easily overlooked by the user which can lead to unintended command calls in other sessions (e.g. something like "rm -rf ..."). The applied patch makes the master mode more visualize by adding "[MASTER]" (or 18n-version) to the title and also by changing the icon to "emblem-important" (this may be a good choice to alert the user; may be there is something better?).


Diffs
-----

  /trunk/KDE/kdebase/apps/konsole/src/SessionController.h 999292 
  /trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 999292 
  /trunk/KDE/kdebase/apps/konsole/src/main.cpp 999292 

Diff: http://reviewboard.kde.org/r/1058/diff


Testing (updated)
-------

Tested with SVN revision 1006339. No problems found with Valgrind.


Thanks,

Thomas