[Konsole-devel] Review Request: Patch to add ZModem Upload and Download

[Thomas Dreibholz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1095/
-----------------------------------------------------------

(Updated 2009-08-28 16:21:04.576670)


Review request for Konsole.


Changes
-------

- Fixed segfault when rz on the remote side is not available.
- Improved Z-Modem progress dialog: using the Escape key, the transfer can now be aborted. Using the Return key, the window can be closed after transfer.


Summary
-------

This patch adds support for Z-modem upload and download to konsole (as it has been available for KDE <4.0).


This addresses bug 200744.
    https://bugs.kde.org/show_bug.cgi?id=200744


Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/konsole/desktop/sessionui.rc 1016687 
  /trunk/KDE/kdebase/apps/konsole/src/Session.cpp 1016687 
  /trunk/KDE/kdebase/apps/konsole/src/SessionController.h 1016687 
  /trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 1016687 
  /trunk/KDE/kdebase/apps/konsole/src/ZModemDialog.cpp 1016687 
  /trunk/KDE/kdebase/apps/konsole/src/main.cpp 1016687 

Diff: http://reviewboard.kde.org/r/1095/diff


Testing
-------

Tested against SVN revision 1006332. Used Valgrind to check for problems -> no problems found.


Thanks,

Thomas