Review Request 129739: Revise investment performance report

[Łukasz Wojniłowicz]

> On Sty 8, 2017, 11:19 rano, Thomas Baumgart wrote:
> > kmymoney/reports/querytable.cpp, line 1025
> > <https://git.reviewboard.kde.org/r/129739/diff/2/?file=488800#file488800line1025>
> >
> >     If we need the dissectTransaction here also, we should refactor it to KMyMoneyUtils. This also helps to remove the include of the editor header file.

Do you mean to carry it over from investtransactioneditor.h to kmymoneyutils.h?


- Łukasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129739/#review101859
-----------------------------------------------------------


On Sty 7, 2017, 8:21 po południu, Łukasz Wojniłowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129739/
> -----------------------------------------------------------
> 
> (Updated Sty 7, 2017, 8:21 po południu)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> 1) "amount" (last column) has been replaced by "ending balance" because
> it's calculated specially for this report by
> QueryTable::constructPerformanceRow,
> 2) "return on investment" column is being calculated also when "ending
> balance" is zero, because zero ending balance doesn't invalidate ROI
> 3) "buys" and "sells" column take "fee amounts" into account during ROI
> calculation, because fees are inseparable from investments,
> 4) "buys" column has minus sign and "sells" column has plus sing,
> because the same notatnion is used by KMM importers.
> 
> 
> Diffs
> -----
> 
>   kmymoney/reports/listtable.cpp 72b605f 
>   kmymoney/reports/querytable.cpp e44f74c 
> 
> Diff: https://git.reviewboard.kde.org/r/129739/diff/
> 
> 
> Testing
> -------
> 
> Reports on stock securities with dividends, completely, partially and not sold at all.
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170108/91cf5236/attachment.html>