Review Request 129739: Revise investment performance report

[Thomas Baumgart]

Hi,

On Sunday 08 January 2017 12:03:23 Łukasz Wojniłowicz wrote:

> > On Sty 8, 2017, 11:19 rano, Thomas Baumgart wrote:
> > > kmymoney/reports/querytable.cpp, line 1025
> > > <https://git.reviewboard.kde.org/r/129739/diff/2/?file=488800#file488800
> > > line1025>> > 
> > >     If we need the dissectTransaction here also, we should refactor it
> > >     to KMyMoneyUtils. This also helps to remove the include of the
> > >     editor header file.
> Do you mean to carry it over from investtransactioneditor.h to
> kmymoneyutils.h?

Yes, something like that if it is feasible.

-- 

Regards

Thomas Baumgart

GPG-FP: E55E D592 F45F 116B 8429   4F99 9C59 DB40 B75D D3BA
-------------------------------------------------------------
Bachelor: One who is footloose & fiance free!
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 225 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170108/463577c5/attachment-0001.sig>