Review Request 129739: Revise investment performance report

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129739/#review101859
-----------------------------------------------------------



Again, I just have done code reading. Besides one comment it looks good to me. Can you take of it first and re-post? Thanks.


kmymoney/reports/querytable.cpp (line 1019)
<https://git.reviewboard.kde.org/r/129739/#comment68147>

    If we need the dissectTransaction here also, we should refactor it to KMyMoneyUtils. This also helps to remove the include of the editor header file.


- Thomas Baumgart


On Jan. 7, 2017, 8:21 nachm., Łukasz Wojniłowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129739/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2017, 8:21 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> 1) "amount" (last column) has been replaced by "ending balance" because
> it's calculated specially for this report by
> QueryTable::constructPerformanceRow,
> 2) "return on investment" column is being calculated also when "ending
> balance" is zero, because zero ending balance doesn't invalidate ROI
> 3) "buys" and "sells" column take "fee amounts" into account during ROI
> calculation, because fees are inseparable from investments,
> 4) "buys" column has minus sign and "sells" column has plus sing,
> because the same notatnion is used by KMM importers.
> 
> 
> Diffs
> -----
> 
>   kmymoney/reports/listtable.cpp 72b605f 
>   kmymoney/reports/querytable.cpp e44f74c 
> 
> Diff: https://git.reviewboard.kde.org/r/129739/diff/
> 
> 
> Testing
> -------
> 
> Reports on stock securities with dividends, completely, partially and not sold at all.
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170108/bd219e01/attachment.html>