[Kmymoney-devel] Review Request 110212: payee: Show transactions from multiple payees

Felipe Tonello eu at felipetonello.com
Mon Mar 10 21:25:47 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110212/
-----------------------------------------------------------

(Updated March 10, 2014, 2:25 p.m.)


Review request for KMymoney.


Changes
-------

Remove unnecessary copy of payee_id QString. Also rebased with current upstream master.


Summary (updated)
-----------------

payee: Show transactions from multiple payees


Repository: kmymoney


Description
-------

It implements Payee Merge operation.

To be able to make this I had to change KPayeeReassignDlg to support other operations then delete. Also I used the delete payee slot and created a new function since merge and delete operations are very similar, avoiding code duplication.


Diffs (updated)
-----

  kmymoney/dialogs/kpayeereassigndlg.h a348d2b9fdc68a7c56a616a862a3373ef35aa0ba 
  kmymoney/dialogs/kpayeereassigndlg.cpp 8bdb25c0b3478c42715fac9f052903ed45b3614c 
  kmymoney/dialogs/kpayeereassigndlgdecl.ui 2cf563d4ea755e8d89ff2587fa677f14453cbaa5 
  kmymoney/kmymoney.h 56e0bd6a3de42bdaa3fbb2f8586495cbb4d555ca 
  kmymoney/kmymoney.cpp 6b96b9790d0ee5b5d34e6cfd382b03e9a103c9e6 
  kmymoney/kmymoneyui.rc 65afc920cef7091e3138c9acf75f73ec96929445 
  kmymoney/views/kpayeesview.h c747e691f6509c7bf60201dfb3cc77e9f939a7c5 
  kmymoney/views/kpayeesview.cpp 7252241886e05f00555d16dc1388b9d6ecef36a2 
  kmymoney/views/kpayeesviewdecl.ui 6efb2ae5f94383851ee2ab15da36187b7079815a 

Diff: https://git.reviewboard.kde.org/r/110212/diff/


Testing (updated)
-------

Normal UI test going trough all the possible options of users input.


Thanks,

Felipe Tonello

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140310/3435126f/attachment.html>


More information about the KMyMoney-devel mailing list