<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/110212/">https://git.reviewboard.kde.org/r/110212/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KMymoney.</div>
<div>By Felipe Tonello.</div>


<p style="color: grey;"><i>Updated March 10, 2014, 2:25 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove unnecessary copy of payee_id QString. Also rebased with current upstream master.</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">payee: Show transactions from multiple payees</pre>
  </td>
 </tr>
</table>





<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It implements Payee Merge operation.

To be able to make this I had to change KPayeeReassignDlg to support other operations then delete. Also I used the delete payee slot and created a new function since merge and delete operations are very similar, avoiding code duplication.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Normal UI test going trough all the possible options of users input.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kmymoney/dialogs/kpayeereassigndlg.h <span style="color: grey">(a348d2b9fdc68a7c56a616a862a3373ef35aa0ba)</span></li>

 <li>kmymoney/dialogs/kpayeereassigndlg.cpp <span style="color: grey">(8bdb25c0b3478c42715fac9f052903ed45b3614c)</span></li>

 <li>kmymoney/dialogs/kpayeereassigndlgdecl.ui <span style="color: grey">(2cf563d4ea755e8d89ff2587fa677f14453cbaa5)</span></li>

 <li>kmymoney/kmymoney.h <span style="color: grey">(56e0bd6a3de42bdaa3fbb2f8586495cbb4d555ca)</span></li>

 <li>kmymoney/kmymoney.cpp <span style="color: grey">(6b96b9790d0ee5b5d34e6cfd382b03e9a103c9e6)</span></li>

 <li>kmymoney/kmymoneyui.rc <span style="color: grey">(65afc920cef7091e3138c9acf75f73ec96929445)</span></li>

 <li>kmymoney/views/kpayeesview.h <span style="color: grey">(c747e691f6509c7bf60201dfb3cc77e9f939a7c5)</span></li>

 <li>kmymoney/views/kpayeesview.cpp <span style="color: grey">(7252241886e05f00555d16dc1388b9d6ecef36a2)</span></li>

 <li>kmymoney/views/kpayeesviewdecl.ui <span style="color: grey">(6efb2ae5f94383851ee2ab15da36187b7079815a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/110212/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>