[Kmymoney-devel] Review Request: Patch which highlights the online statement balance if different from current file balance

[Thomas Baumgart]

> On Dec. 3, 2011, 8:46 a.m., Thomas Baumgart wrote:
> > Ship It!
> 
> Marko Käning wrote:
>     I'll check whether git is working today and try to commit the patch. :-)
>     
>     Thanks again, Thomas, for all your help!
> 
> Marko Käning wrote:
>     identity.kde.org doesn't allow me to add ssh keys, so I guess you'll have to commit this patch, Thomas.
> 
> Marko Käning wrote:
>     ACTUALLY, THIS IS NOT YET COMPLETE!!!
>     
>     I've seen a case now which leads to a red highlighting although the balances are fine. That was due to the fact that obviously future transactions aren't considered properly.
>     
>     I guess we need to improve the balance check for cases like this!
> 
> Marko Käning wrote:
>     This line
>     ---
>         MyMoneyMoney balance(account.value("lastStatementBalance"));
>     ---
>     should actually not simply take the value of "lastStatementBalance", but rather use the date of "lastImportedTransactionDate" to determine the correct balance for that same date.
>     
>     Since I do not know how to ask the account class for the balance at a specific date I have to ask for your help.

No, the following statements do just what they should do:

  MyMoneyMoney balance(acc.value("lastStatementBalance"));

converts the balance received from the bank and converts it into a MyMoneyMoney value.

  MyMoneyMoney accBalance = this->balance(acc.id(), QDate::fromString(acc.value("lastImportedTransactionDate")));

calculates the file balance for the date that was used by the bank to calculate the online balance.

So where is the problem?


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103264/#review8674
-----------------------------------------------------------


On Dec. 2, 2011, 10:43 p.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103264/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2011, 10:43 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> Highlighting of online statement balance with red background and
> highlighted text if file balance and online balance are different.
> (This patch was put together from Thomas' and Cristian's advice on ML)
> 
> 
> This addresses bug 287494.
>     http://bugs.kde.org/show_bug.cgi?id=287494
> 
> 
> Diffs
> -----
> 
>   kmymoney/mymoney/mymoneyfile.h d44e2ea 
>   kmymoney/mymoney/mymoneyfile.cpp f573f9a 
>   kmymoney/mymoney/mymoneyfiletest.h ad5c687 
>   kmymoney/mymoney/mymoneyfiletest.cpp a3c17ed 
>   kmymoney/widgets/register.h 8cd1a32 
>   kmymoney/widgets/register.cpp e62fe63 
> 
> Diff: http://git.reviewboard.kde.org/r/103264/diff/diff
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Screenshots
> -----------
> 
> small snapshot showing the highlighted group marker
>   http://git.reviewboard.kde.org/r/103264/s/345/
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20111208/8c72df0e/attachment-0001.html>