<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103264/">http://git.reviewboard.kde.org/r/103264/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 3rd, 2011, 8:46 a.m., <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
<p>On December 3rd, 2011, 10:16 a.m., <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'll check whether git is working today and try to commit the patch. :-)
Thanks again, Thomas, for all your help!</pre>
</blockquote>
<p>On December 3rd, 2011, 10:32 a.m., <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">identity.kde.org doesn't allow me to add ssh keys, so I guess you'll have to commit this patch, Thomas.</pre>
</blockquote>
<p>On December 7th, 2011, 7:48 p.m., <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ACTUALLY, THIS IS NOT YET COMPLETE!!!
I've seen a case now which leads to a red highlighting although the balances are fine. That was due to the fact that obviously future transactions aren't considered properly.
I guess we need to improve the balance check for cases like this!</pre>
</blockquote>
<p>On December 7th, 2011, 9:47 p.m., <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This line
---
MyMoneyMoney balance(account.value("lastStatementBalance"));
---
should actually not simply take the value of "lastStatementBalance", but rather use the date of "lastImportedTransactionDate" to determine the correct balance for that same date.
Since I do not know how to ask the account class for the balance at a specific date I have to ask for your help.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, the following statements do just what they should do:
MyMoneyMoney balance(acc.value("lastStatementBalance"));
converts the balance received from the bank and converts it into a MyMoneyMoney value.
MyMoneyMoney accBalance = this->balance(acc.id(), QDate::fromString(acc.value("lastImportedTransactionDate")));
calculates the file balance for the date that was used by the bank to calculate the online balance.
So where is the problem?</pre>
<br />
<p>- Thomas</p>
<br />
<p>On December 2nd, 2011, 10:43 p.m., Marko Käning wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Marko Käning.</div>
<p style="color: grey;"><i>Updated Dec. 2, 2011, 10:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Highlighting of online statement balance with red background and
highlighted text if file balance and online balance are different.
(This patch was put together from Thomas' and Cristian's advice on ML)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=287494">287494</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/mymoney/mymoneyfile.h <span style="color: grey">(d44e2ea)</span></li>
<li>kmymoney/mymoney/mymoneyfile.cpp <span style="color: grey">(f573f9a)</span></li>
<li>kmymoney/mymoney/mymoneyfiletest.h <span style="color: grey">(ad5c687)</span></li>
<li>kmymoney/mymoney/mymoneyfiletest.cpp <span style="color: grey">(a3c17ed)</span></li>
<li>kmymoney/widgets/register.h <span style="color: grey">(8cd1a32)</span></li>
<li>kmymoney/widgets/register.cpp <span style="color: grey">(e62fe63)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103264/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103264/s/345/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/11/27/KMM-online-balance-highlight_400x100.tiff" style="border: 1px black solid;" alt="small snapshot showing the highlighted group marker" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>