[Kmymoney-devel] Review Request: Patch which highlights the online statement balance if different from current file balance

[Marko Käning]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103264/
-----------------------------------------------------------

(Updated Dec. 11, 2011, 10:53 p.m.)


Review request for KMymoney.


Changes
-------

Thomas' final patch now uses the correct Qt::ISODate date formatting.
This fixes the latest issue found with an erroneously non-matching balance highlighting.


Description
-------

Highlighting of online statement balance with red background and
highlighted text if file balance and online balance are different.
(This patch was put together from Thomas' and Cristian's advice on ML)


This addresses bug 287494.
    http://bugs.kde.org/show_bug.cgi?id=287494


Diffs (updated)
-----

  kmymoney/mymoney/mymoneyfile.h d44e2ea 
  kmymoney/mymoney/mymoneyfile.cpp 57d7576 
  kmymoney/mymoney/mymoneyfiletest.h ad5c687 
  kmymoney/mymoney/mymoneyfiletest.cpp a3c17ed 
  kmymoney/widgets/register.h 8cd1a32 
  kmymoney/widgets/register.cpp e62fe63 

Diff: http://git.reviewboard.kde.org/r/103264/diff/diff


Testing
-------

Yes


Screenshots
-----------

small snapshot showing the highlighted group marker
  http://git.reviewboard.kde.org/r/103264/s/345/


Thanks,

Marko Käning

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20111211/b7cc7466/attachment.html>