[Kmymoney-devel] KMyMoney: proposal to replace hard coded utf-8 in KReportsView::KReportTab
asoliverez at gmail.com
Wed Mar 31 04:14:07 CEST 2010
On Tue, Mar 30, 2010 at 6:47 AM, Bernd Gonsior <bgo at freeplexx.de> wrote:
>> Now, for a more permanent fix of this issue, I'd like to move the
>> whole HTML generation code to a separate class. That would move a lot
>> of code which doesn't really belong to the view out of the main class.
>> Would you like to take on that?
> If there is some time to do that, yes, i can do. The HTML
> generation code seems to be a bit
> distributed (PivotTable::renderHTML, ListTable::renderHTML,
> KReportsView::KReportTab::createTable) and is sometimes mixed
> with csv generation. Would you like to have a HTML generation class
> for KReportsView only or something more general? When should it
> be done?
Both PivotTable and ListTable inherit ReportTable, which currently
serves as interfaces for both. Since this code is common to both
classes, I think it should go into that class. The next freeze in on
April 30th, so you have until then, if you are interested.
The html code in PivotTable and ListTable is not to be touched at this
point. It's fairly complex, they do different stuff in different ways,
and I wouldn't like to mess with it at this point in the lifecycle.
More information about the KMyMoney-devel