[Kmymoney-devel] Review Request: Remove Qt3Support from KFindTransactionsDlg

[Alvaro Soliverez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4465/#review6305
-----------------------------------------------------------


It looks fine now.

A small issue. In the payee list, you can see the root decoration. Calling setRootIsDecorated(false) should get rid of that.

Other than that, you could take the opportunity and port the QDialog to a KDialog.


- Alvaro


On 2010-06-28 03:05:36, Fernando Vilas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4465/
> -----------------------------------------------------------
> 
> (Updated 2010-06-28 03:05:36)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> This ports the remaining Q3ListView in the dialog to QTreeWidget. It also ports the associated KMyMoneyCheckListItem that is only used in that dialog.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/dialogs/kfindtransactiondlg.h 1143519 
>   /trunk/extragear/office/kmymoney/kmymoney/dialogs/kfindtransactiondlg.cpp 1143519 
>   /trunk/extragear/office/kmymoney/kmymoney/dialogs/kfindtransactiondlgdecl.ui 1143519 
>   /trunk/extragear/office/kmymoney/kmymoney/widgets/CMakeLists.txt 1143519 
>   /trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneychecklistitem.h 1143519 
>   /trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneychecklistitem.cpp 1143519 
>   /trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneylistviewitem.h 1143519 
>   /trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp 1143519 
> 
> Diff: http://reviewboard.kde.org/r/4465/diff
> 
> 
> Testing
> -------
> 
> The app builds correctly, and the dialog looks correct to me. This is a feature I do not normally use, so I am requesting additional testing before I commit the change.
> 
> 
> Thanks,
> 
> Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100628/90382921/attachment.htm