[Kmymoney-devel] Review Request: Remove Qt3Support from KFindTransactionsDlg

Fernando Vilas fvilas at iname.com
Mon Jun 28 05:05:36 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4465/
-----------------------------------------------------------

(Updated 2010-06-28 03:05:36.090437)


Review request for kmymoney.


Changes
-------

Add in a separate patch that removes the unused KMyMoneyListViewItem code.


Summary
-------

This ports the remaining Q3ListView in the dialog to QTreeWidget. It also ports the associated KMyMoneyCheckListItem that is only used in that dialog.


Diffs (updated)
-----

  /trunk/extragear/office/kmymoney/kmymoney/dialogs/kfindtransactiondlg.h 1143519 
  /trunk/extragear/office/kmymoney/kmymoney/dialogs/kfindtransactiondlg.cpp 1143519 
  /trunk/extragear/office/kmymoney/kmymoney/dialogs/kfindtransactiondlgdecl.ui 1143519 
  /trunk/extragear/office/kmymoney/kmymoney/widgets/CMakeLists.txt 1143519 
  /trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneychecklistitem.h 1143519 
  /trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneychecklistitem.cpp 1143519 
  /trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneylistviewitem.h 1143519 
  /trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp 1143519 

Diff: http://reviewboard.kde.org/r/4465/diff


Testing
-------

The app builds correctly, and the dialog looks correct to me. This is a feature I do not normally use, so I am requesting additional testing before I commit the change.


Thanks,

Fernando

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100628/fcfd304b/attachment.htm 


More information about the KMyMoney-devel mailing list