<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4465/">http://reviewboard.kde.org/r/4465/</a>
</td>
</tr>
</table>
<br />
<pre>It looks fine now.
A small issue. In the payee list, you can see the root decoration. Calling setRootIsDecorated(false) should get rid of that.
Other than that, you could take the opportunity and port the QDialog to a KDialog.
</pre>
<br />
<p>- Alvaro</p>
<br />
<p>On June 28th, 2010, 3:05 a.m., Fernando Vilas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Fernando Vilas.</div>
<p style="color: grey;"><i>Updated 2010-06-28 03:05:36</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">This ports the remaining Q3ListView in the dialog to QTreeWidget. It also ports the associated KMyMoneyCheckListItem that is only used in that dialog.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">The app builds correctly, and the dialog looks correct to me. This is a feature I do not normally use, so I am requesting additional testing before I commit the change.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/extragear/office/kmymoney/kmymoney/dialogs/kfindtransactiondlg.h <span style="color: grey">(1143519)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/dialogs/kfindtransactiondlg.cpp <span style="color: grey">(1143519)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/dialogs/kfindtransactiondlgdecl.ui <span style="color: grey">(1143519)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/widgets/CMakeLists.txt <span style="color: grey">(1143519)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneychecklistitem.h <span style="color: grey">(1143519)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneychecklistitem.cpp <span style="color: grey">(1143519)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneylistviewitem.h <span style="color: grey">(1143519)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp <span style="color: grey">(1143519)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4465/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>