[Kmymoney-devel] Review Request: Remove Qt3Support from KFindTransactionsDlg

[Alvaro Soliverez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4465/#review6302
-----------------------------------------------------------



/trunk/extragear/office/kmymoney/kmymoney/dialogs/kfindtransactiondlg.h
<http://reviewboard.kde.org/r/4465/#comment5981>

    Why is this change? Isn't it better to use < > instead of "" when possible?


I get this error when trying to build with your patch.

[ 32%] Building CXX object kmymoney/widgets/CMakeFiles/kmymoney_base.dir/kmymoneylistviewitem.cpp.o
/home/al/desarrollo/kmm/kde4/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp: En la función miembro ‘bool KMyMoneyListViewItem::isAlternate()’:                                                                   
/home/al/desarrollo/kmm/kde4/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp:99:34: error: ‘class KMyMoneyCheckListItem’ no tiene un miembro llamado ‘m_isKnown’
/home/al/desarrollo/kmm/kde4/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp:101:35: error: ‘class KMyMoneyCheckListItem’ no tiene un miembro llamado ‘m_isOdd’
/home/al/desarrollo/kmm/kde4/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp:110:28: error: ‘class KMyMoneyCheckListItem’ no tiene un miembro llamado ‘m_isOdd’
/home/al/desarrollo/kmm/kde4/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp:121:17: error: ‘class KMyMoneyCheckListItem’ no tiene un miembro llamado ‘m_isOdd’
/home/al/desarrollo/kmm/kde4/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp:122:17: error: ‘class KMyMoneyCheckListItem’ no tiene un miembro llamado ‘m_isKnown’
/home/al/desarrollo/kmm/kde4/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp:123:63: error: ‘class KMyMoneyCheckListItem’ no tiene un miembro llamado ‘nextSibling’
/home/al/desarrollo/kmm/kde4/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp:124:64: error: ‘class KMyMoneyCheckListItem’ no tiene un miembro llamado ‘nextSibling’
make[2]: *** [kmymoney/widgets/CMakeFiles/kmymoney_base.dir/kmymoneylistviewitem.cpp.o] Error 1
make[1]: *** [kmymoney/widgets/CMakeFiles/kmymoney_base.dir/all] Error 2
make: *** [all] Error 2


Keep in mind that I'm using gcc 4.5.0, which is a lot stricter about includes and inheritance than 4.4.x

- Alvaro


On 2010-06-27 22:18:25, Fernando Vilas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4465/
> -----------------------------------------------------------
> 
> (Updated 2010-06-27 22:18:25)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> This ports the remaining Q3ListView in the dialog to QTreeWidget. It also ports the associated KMyMoneyCheckListItem that is only used in that dialog.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/dialogs/kfindtransactiondlg.h 1143473 
>   /trunk/extragear/office/kmymoney/kmymoney/dialogs/kfindtransactiondlg.cpp 1143473 
>   /trunk/extragear/office/kmymoney/kmymoney/dialogs/kfindtransactiondlgdecl.ui 1143473 
>   /trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneychecklistitem.h 1143473 
>   /trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneychecklistitem.cpp 1143473 
> 
> Diff: http://reviewboard.kde.org/r/4465/diff
> 
> 
> Testing
> -------
> 
> The app builds correctly, and the dialog looks correct to me. This is a feature I do not normally use, so I am requesting additional testing before I commit the change.
> 
> 
> Thanks,
> 
> Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100628/7c01786d/attachment.htm