<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4465/">http://reviewboard.kde.org/r/4465/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/4465/diff/1/?file=29878#file29878line35" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/extragear/office/kmymoney/kmymoney/dialogs/kfindtransactiondlg.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">35</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"><span class="cp">#include <span class="hl"><</span>mymoneyutils.h<span class="hl">></span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">35</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"><span class="cp">#include <span class="hl">"</span>mymoneyutils.h<span class="hl">"</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em">Why is this change? Isn't it better to use < > instead of "" when possible?</pre>
</div>
<br />
<pre>I get this error when trying to build with your patch.
[ 32%] Building CXX object kmymoney/widgets/CMakeFiles/kmymoney_base.dir/kmymoneylistviewitem.cpp.o
/home/al/desarrollo/kmm/kde4/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp: En la función miembro ‘bool KMyMoneyListViewItem::isAlternate()’:
/home/al/desarrollo/kmm/kde4/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp:99:34: error: ‘class KMyMoneyCheckListItem’ no tiene un miembro llamado ‘m_isKnown’
/home/al/desarrollo/kmm/kde4/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp:101:35: error: ‘class KMyMoneyCheckListItem’ no tiene un miembro llamado ‘m_isOdd’
/home/al/desarrollo/kmm/kde4/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp:110:28: error: ‘class KMyMoneyCheckListItem’ no tiene un miembro llamado ‘m_isOdd’
/home/al/desarrollo/kmm/kde4/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp:121:17: error: ‘class KMyMoneyCheckListItem’ no tiene un miembro llamado ‘m_isOdd’
/home/al/desarrollo/kmm/kde4/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp:122:17: error: ‘class KMyMoneyCheckListItem’ no tiene un miembro llamado ‘m_isKnown’
/home/al/desarrollo/kmm/kde4/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp:123:63: error: ‘class KMyMoneyCheckListItem’ no tiene un miembro llamado ‘nextSibling’
/home/al/desarrollo/kmm/kde4/kmymoney/kmymoney/widgets/kmymoneylistviewitem.cpp:124:64: error: ‘class KMyMoneyCheckListItem’ no tiene un miembro llamado ‘nextSibling’
make[2]: *** [kmymoney/widgets/CMakeFiles/kmymoney_base.dir/kmymoneylistviewitem.cpp.o] Error 1
make[1]: *** [kmymoney/widgets/CMakeFiles/kmymoney_base.dir/all] Error 2
make: *** [all] Error 2
Keep in mind that I'm using gcc 4.5.0, which is a lot stricter about includes and inheritance than 4.4.x</pre>
<p>- Alvaro</p>
<br />
<p>On June 27th, 2010, 10:18 p.m., Fernando Vilas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Fernando Vilas.</div>
<p style="color: grey;"><i>Updated 2010-06-27 22:18:25</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">This ports the remaining Q3ListView in the dialog to QTreeWidget. It also ports the associated KMyMoneyCheckListItem that is only used in that dialog.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">The app builds correctly, and the dialog looks correct to me. This is a feature I do not normally use, so I am requesting additional testing before I commit the change.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/extragear/office/kmymoney/kmymoney/dialogs/kfindtransactiondlg.h <span style="color: grey">(1143473)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/dialogs/kfindtransactiondlg.cpp <span style="color: grey">(1143473)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/dialogs/kfindtransactiondlgdecl.ui <span style="color: grey">(1143473)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneychecklistitem.h <span style="color: grey">(1143473)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneychecklistitem.cpp <span style="color: grey">(1143473)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4465/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>