[Kmymoney-devel] Summary of the IRC meeting on 2010-06-03

[Fernando Vilas]

On Friday, June 04, 2010 12:46:30 Thomas Baumgart wrote:
> Hi all,
> 
> on Friday 04 June 2010 04:16:29 Alvaro Soliverez wrote:
> > On Thu, Jun 3, 2010 at 10:41 PM, Fernando Vilas <fvilas at iname.com> wrote:
> > > On Thursday, June 03, 2010 12:58:45 Thomas Baumgart wrote:
> > >> Hi all,
> > >> 
> > >> this is a summary of today's meeting on #kmymoney
> > > 
> > > [...]
> > > 
> > >> - Around 300 more issues are reported when running krazy locally.
> > >> Developers are encouraged to install krazy locally to see them.
> > > 
> > > To be fair, about 255 of those are in the crashy check. I looked into
> > > those last night, and most of them seem to be for the QDialog::exec()
> > > check returning a false positive for QSqlQuery::exec().
> 
> Not sure, here's the exception list from that check:
> 
>   QSqlQuery|KApplication|.*Job|.*App
> 
> We are using MyMoneySqlQuery which of course is not part of the exception.
> And then we have constructs like:
> 
> 
> 
>   MyMoneySqlQuery q(this);
> 
>   if (!q.exec() || !q.next()) {
>     QSqlQuery q(*this);
> 
>     if (!q.exec()) {
> 
> No wonder that the little PERL based test is in trouble :)

The docs on QSqlQuery say that it is no longer a good idea to subclass it like 
we did with MyMoneySqlQuery. I'm working on a patch now. As for the constructs 
that we use, we will have to see if they pass krazy. If not, I'll exclude the 
calls from the check.

-- 
Thanks,
Fernando Vilas
fvilas at iname.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100604/c253eb1a/attachment.sig