[Kmymoney-devel] Review Request: Fix a mingw4 link problem

[Cristian Onet]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4924/#review6854
-----------------------------------------------------------



trunk/extragear/office/kmymoney/kmymoney/CMakeLists.txt
<http://reviewboard.kde.org/r/4924/#comment6762>

    This diff leaves only this error ..\bin\libkmymoney_base.a(kmymoneycurrencyselector.cpp.obj):kmymoneycurrencyselector.cpp:(.text$_ZN18QAlgorithmsPrivate11qSortHelperIN5QListI15MyMoneySecurityE8iteratorES2_5qLessIS2_EEEvT_S7_RKT0_T1_[void QAlgorithmsPrivate::qSortHelper<QList<MyMoneySecurity>::iterator, MyMoneySecurity, qLess<MyMoneySecurity> >(QList<MyMoneySecurity>::iterator, QList<MyMoneySecurity>::iterator, MyMoneySecurity const&, qLess<MyMoneySecurity>)]+0x36b): undefined reference to `_imp___ZNK15MyMoneySecurityltERKS_' which is solved by moving kmymoneycurrencyselector.cpp to the critical sources although it does not contain the KMM_DESIGNER flag.


- Cristian


On 2010-08-07 16:19:33, Cristian Onet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4924/
> -----------------------------------------------------------
> 
> (Updated 2010-08-07 16:19:33)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> This patch fixes this problem http://winkde.org/pub/kde/ports/win32/releases/nightly/20100806/logs/log-mingw4-extragear_kmymoney.txt
> I don't have a really good explanation for this patch other then it fixes the problem so any better solutions are welcome. Unless none appear until the stable release we should really commit this so we can go stable on Windows also.
> 
> 
> Diffs
> -----
> 
>   trunk/extragear/office/kmymoney/kmymoney/CMakeLists.txt 1159992 
>   trunk/extragear/office/kmymoney/kmymoney/widgets/CMakeLists.txt 1159992 
> 
> Diff: http://reviewboard.kde.org/r/4924/diff
> 
> 
> Testing
> -------
> 
> Tested it on Linux/gcc and Windows/mingw4 and it works.
> 
> 
> Thanks,
> 
> Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100807/a7429e44/attachment.htm