<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4924/">http://reviewboard.kde.org/r/4924/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/4924/diff/1/?file=33072#file33072line65" style="color: black; font-weight: bold; text-decoration: underline;">trunk/extragear/office/kmymoney/kmymoney/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">65</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> views reports kmymoney_common</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">65</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> views reports kmymoney_<span class="hl">base kmymoney_</span>common</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This diff leaves only this error ..\bin\libkmymoney_base.a(kmymoneycurrencyselector.cpp.obj):kmymoneycurrencyselector.cpp:(.text$_ZN18QAlgorithmsPrivate11qSortHelperIN5QListI15MyMoneySecurityE8iteratorES2_5qLessIS2_EEEvT_S7_RKT0_T1_[void QAlgorithmsPrivate::qSortHelper<QList<MyMoneySecurity>::iterator, MyMoneySecurity, qLess<MyMoneySecurity> >(QList<MyMoneySecurity>::iterator, QList<MyMoneySecurity>::iterator, MyMoneySecurity const&, qLess<MyMoneySecurity>)]+0x36b): undefined reference to `_imp___ZNK15MyMoneySecurityltERKS_' which is solved by moving kmymoneycurrencyselector.cpp to the critical sources although it does not contain the KMM_DESIGNER flag.</pre>
</div>
<br />
<p>- Cristian</p>
<br />
<p>On August 7th, 2010, 4:19 p.m., Cristian Onet wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Cristian Onet.</div>
<p style="color: grey;"><i>Updated 2010-08-07 16:19:33</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fixes this problem http://winkde.org/pub/kde/ports/win32/releases/nightly/20100806/logs/log-mingw4-extragear_kmymoney.txt
I don't have a really good explanation for this patch other then it fixes the problem so any better solutions are welcome. Unless none appear until the stable release we should really commit this so we can go stable on Windows also.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested it on Linux/gcc and Windows/mingw4 and it works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/extragear/office/kmymoney/kmymoney/CMakeLists.txt <span style="color: grey">(1159992)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/widgets/CMakeLists.txt <span style="color: grey">(1159992)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4924/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>