[Kmymoney-devel] Review Request: Fix a mingw4 link problem

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4924/#review6855
-----------------------------------------------------------


Does it also work on MSVC? If yes, I'd say ship it.

- Thomas


On 2010-08-07 16:19:33, Cristian Onet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4924/
> -----------------------------------------------------------
> 
> (Updated 2010-08-07 16:19:33)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> This patch fixes this problem http://winkde.org/pub/kde/ports/win32/releases/nightly/20100806/logs/log-mingw4-extragear_kmymoney.txt
> I don't have a really good explanation for this patch other then it fixes the problem so any better solutions are welcome. Unless none appear until the stable release we should really commit this so we can go stable on Windows also.
> 
> 
> Diffs
> -----
> 
>   trunk/extragear/office/kmymoney/kmymoney/CMakeLists.txt 1159992 
>   trunk/extragear/office/kmymoney/kmymoney/widgets/CMakeLists.txt 1159992 
> 
> Diff: http://reviewboard.kde.org/r/4924/diff
> 
> 
> Testing
> -------
> 
> Tested it on Linux/gcc and Windows/mingw4 and it works.
> 
> 
> Thanks,
> 
> Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100807/fe438743/attachment.htm