[Kmymoney-devel] First contribution : Check single-char QString operations for efficiency

[Alvaro Soliverez]

Hello Michaël,
glad to have you here. I am reviewing the patch now.

Did you run the unit tests after your changes? That's a good safety measure
after making this kind of changes.

make -test should do the trick, provided you enabled the unit tests on
cmake.

It is in SVN now, save for a few files that I held back because I'm working
on them myself.

Thanks for your contribution.

Regards,
Alvaro


On Sat, Oct 10, 2009 at 7:05 AM, Michaël Lhomme <papylhomme at gmail.com>wrote:

> Hello,
>
> As I'm willing to contribute to the port of KMM to kde4, here is my first
> patch. I fixed problems on "Check single-char QString operations for
> efficiency" reported by krazy.
>
> Please find attached the patch generated on revision 1033419.
>
> About running KMM for kde4, is there any problems to switch between the
> version for kde3 and the version for kde4 ? (difference in file format,
> problems with 2 versions installed...)
>
> Regards,
>
> Michaël Lhomme
>
> _______________________________________________
> KMyMoney-devel mailing list
> KMyMoney-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kmymoney-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20091010/cb6159bd/attachment.htm