Hello Michaël,<br>glad to have you here. I am reviewing the patch now.<br><br>Did you run the unit tests after your changes? That's a good safety measure after making this kind of changes.<br><br>make -test should do the trick, provided you enabled the unit tests on cmake.<br>
<br>It is in SVN now, save for a few files that I held back because I'm working on them myself.<br><br>Thanks for your contribution.<br><br>Regards,<br>Alvaro<br><br><br><div class="gmail_quote">On Sat, Oct 10, 2009 at 7:05 AM, Michaël Lhomme <span dir="ltr"><<a href="mailto:papylhomme@gmail.com">papylhomme@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div>Hello,</div><div><br></div><div>As I'm willing to contribute to the port of KMM to kde4, here is my first patch. I fixed problems on "Check single-char QString operations for efficiency" reported by krazy.</div>
<div><br></div><div>Please find attached the patch generated on revision 1033419.</div><div><br></div><div>About running KMM for kde4, is there any problems to switch between the version for kde3 and the version for kde4 ? (difference in file format, problems with 2 versions installed...)</div>
<div><br></div><div>Regards,</div><div> <br></div>Michaël Lhomme<br>
<br>_______________________________________________<br>
KMyMoney-devel mailing list<br>
<a href="mailto:KMyMoney-devel@kde.org">KMyMoney-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kmymoney-devel" target="_blank">https://mail.kde.org/mailman/listinfo/kmymoney-devel</a><br>
<br></blockquote></div><br>