[Kmymoney-devel] First contribution : Check single-char QString operations for efficiency

[Michaël Lhomme]

Le samedi 10 octobre 2009 16:55:10, Alvaro Soliverez a écrit :
> Hello Michaël,
> glad to have you here. I am reviewing the patch now.
> 
> Did you run the unit tests after your changes? That's a good safety measure
> after making this kind of changes.
> 
> make -test should do the trick, provided you enabled the unit tests on
> cmake.
> 
> It is in SVN now, save for a few files that I held back because I'm working
> on them myself.
> 
> Thanks for your contribution.
> 
> Regards,
> Alvaro
> 
> On Sat, Oct 10, 2009 at 7:05 AM, Michaël Lhomme <papylhomme at gmail.com>wrote:
> > Hello,
> >
> > As I'm willing to contribute to the port of KMM to kde4, here is my first
> > patch. I fixed problems on "Check single-char QString operations for
> > efficiency" reported by krazy.
> >
> > Please find attached the patch generated on revision 1033419.
> >
> > About running KMM for kde4, is there any problems to switch between the
> > version for kde3 and the version for kde4 ? (difference in file format,
> > problems with 2 versions installed...)
> >
> > Regards,
> >
> > Michaël Lhomme

Hello,

unit test were not enabled, so I have just tested by compiling and running 
KMM. I fixed this and now test are enabled. Just a minor patch for this : 
README.cmake contains a mistake on enabling tests.

If it's ok for other developers, I think the next job I'll focus on is the 
headers problems reported by krazy.

Regards,

Michael 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unit_test.patch
Type: text/x-patch
Size: 468 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kmymoney-devel/attachments/20091011/6a86af2f/attachment.patch