[Kmymoney-devel] kmymoneyselector

[Cristian Oneţ]

On Tue, Jul 28, 2009 at 3:47 AM, Alvaro Soliverez<asoliverez at gmail.com> wrote:
>
>
> On Mon, Jul 27, 2009 at 12:44 PM, Cristian Oneţ <onet.cristian at gmail.com>
> wrote:
>>
>> On Mon, Jul 27, 2009 at 5:40 PM, Alvaro Soliverez<asoliverez at gmail.com>
>> wrote:
>> > Hello all,
>> > I have been working on porting this class to a KDE4 one. From what I
>> > understand, this class should be moved to a proxy, because it deals
>> > primarily with filtering items.
>> > It has some other functionality, which should be moved to the
>> > corresponding
>> > widgets because it is mostly about whether items can be selected or
>> > checked.
>> > This class is inherited by kmymoneyaccountselector, and used by
>> > kmymoneycombo, and kmymoneycompletion, so all those will have to change
>> > too
>> > in time.
>> > In a first stage, I will only change kmymoneyaccountselector to a KDE4
>> > widget, to prove the approach is solid.
>> > Also, this will help get the ledgers in a usable state.
>> >
>> > Any thoughts on this?
>> As a developer I would say yeah go ahead :) but as a user who would
>> like to get his hands as fast as possible on a usable (just the basics
>> really no online banking and stuff) kde4 version of kmymoney (since
>> its the only application that keeps my kde-libs 3.5 on my system) I
>> would say: Wouldn't it be easier to make it work without re-writing
>> and refactor it after it works?
>> But if you judge that it's better this way it's OK from my POW. I know
>> that while searching for the reason the widgets pop-ups were not
>> working (this is the way I learned about the Qt::Popup widget flag :)
>> ) I saw that the Qt combo widget had the same architecture and I was
>> thinking that maybe it would be easier to replace the kmymoney widget
>> with a corresponding Qt widget but then I taught of all the small
>> customizations that the kmymoney widget has and I said to myself:
>> leave it that way for now...
>
> Yes, I have been looking at the widget for some time, and I think that it
> will be easier to port it, rather than try to fix it.
> Just like you, I'm very wary of getting into porting the widget to the Qt4
> widget. That's why I sent this email on the first place.
> I will look a little further into it before doing any real work.
Well to really know if the kmymoney widget could work or not on kde4
we would first have to port all the disabled code preceded by
"#warning port to kde4". I don't think that's such a hard task, maybe
it's not that interesting work but the results are immediately visible
and that makes it worth doing it.

> In the meantime, is there any other area you think I could get my hands
> dirty on? :)
As I said above the "#warning port to kde4" would "need some love" as
some say :). For example porting the code from the kmymoney combo
paintEvent made the combo work without problems and I think that this
is the shortest path to make the other widgets work to. It's just a
matter of finding the qt4/kde4 correspondent of the old code :).

There are also stuff that does no work like, and as I suspect they
will not get fixed by porting all the "#warning port to kde4" code:
- zoom factor in the khtmlpart of khomeview
- configurable icon sizes of the pages
- figure out a color usage scheme so it would look good on any style
for example in the default style the active text and background are
pink so we sure can't use that color for the title label for example
like we used to do
- when creating a new schedule there is a failing assert, something to
do with a -1 (this also happens in 0.9.3-CVS I think)

Regards,

Cristian