New Defects reported by Coverity Scan for krita
scan-admin at coverity.com
scan-admin at coverity.com
Thu Sep 26 19:02:24 BST 2019
Hi,
Please find the latest report on new defect(s) introduced to krita found with Coverity Scan.
5 new defect(s) introduced to krita found with Coverity Scan.
84 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)
** CID 253687: Incorrect expression (IDENTICAL_BRANCHES)
/plugins/extensions/pykrita/sip/krita/sipkritapart0.cpp: 16599 in meth_FilterMask_type(_object *, _object *)()
________________________________________________________________________________________________________
*** CID 253687: Incorrect expression (IDENTICAL_BRANCHES)
/plugins/extensions/pykrita/sip/krita/sipkritapart0.cpp: 16599 in meth_FilterMask_type(_object *, _object *)()
16593 #line 26 "/usr/share/sip/PyQt5/QtCore/qmetaobject.sip"
16594 #include <qmetaobject.h>
16595 #line 16834 "/home/boud/dev/b-krita/plugins/extensions/pykrita/sip/./krita/sipkritapart0.cpp"
16596 #line 26 "/usr/share/sip/PyQt5/QtCore/qcoreevent.sip"
16597 #include <qcoreevent.h>
16598 #line 16837 "/home/boud/dev/b-krita/plugins/extensions/pykrita/sip/./krita/sipkritapart0.cpp"
>>> CID 253687: Incorrect expression (IDENTICAL_BRANCHES)
>>> Ternary expression on condition "sipSelfWasArg" has identical then and else expressions: "QString(sipCpp->FilterMask::type())". Should one of the expressions be modified, or the entire ternary expression replaced?
16599 #line 247 "/usr/share/sip/PyQt5/QtCore/qcoreevent.sip"
16600 #include <qcoreevent.h>
16601 #line 16840 "/home/boud/dev/b-krita/plugins/extensions/pykrita/sip/./krita/sipkritapart0.cpp"
16602 #line 235 "/usr/share/sip/PyQt5/QtCore/qcoreevent.sip"
16603 #include <qcoreevent.h>
16604 #line 16843 "/home/boud/dev/b-krita/plugins/extensions/pykrita/sip/./krita/sipkritapart0.cpp"
** CID 253686: Incorrect expression (IDENTICAL_BRANCHES)
/plugins/extensions/pykrita/sip/krita/sipkritapart0.cpp: 18332 in meth_GroupLayer_type(_object *, _object *)()
________________________________________________________________________________________________________
*** CID 253686: Incorrect expression (IDENTICAL_BRANCHES)
/plugins/extensions/pykrita/sip/krita/sipkritapart0.cpp: 18332 in meth_GroupLayer_type(_object *, _object *)()
18326 #line 26 "/usr/share/sip/PyQt5/QtCore/qthread.sip"
18327 #include <qthread.h>
18328 #line 18585 "/home/boud/dev/b-krita/plugins/extensions/pykrita/sip/./krita/sipkritapart0.cpp"
18329 #line 26 "/usr/share/sip/PyQt5/QtCore/qnamespace.sip"
18330 #include <qnamespace.h>
18331 #line 18588 "/home/boud/dev/b-krita/plugins/extensions/pykrita/sip/./krita/sipkritapart0.cpp"
>>> CID 253686: Incorrect expression (IDENTICAL_BRANCHES)
>>> Ternary expression on condition "sipSelfWasArg" has identical then and else expressions: "QString(sipCpp->GroupLayer::type())". Should one of the expressions be modified, or the entire ternary expression replaced?
18332 #line 26 "/usr/share/sip/PyQt5/QtCore/qregexp.sip"
18333 #include <qregexp.h>
18334 #line 18591 "/home/boud/dev/b-krita/plugins/extensions/pykrita/sip/./krita/sipkritapart0.cpp"
18335 #line 26 "/usr/share/sip/PyQt5/QtCore/qregularexpression.sip"
18336 #include <qregularexpression.h>
18337 #line 18594 "/home/boud/dev/b-krita/plugins/extensions/pykrita/sip/./krita/sipkritapart0.cpp"
** CID 253685: Incorrect expression (IDENTICAL_BRANCHES)
/plugins/extensions/pykrita/sip/krita/sipkritapart0.cpp: 16310 in meth_SelectionMask_type(_object *, _object *)()
________________________________________________________________________________________________________
*** CID 253685: Incorrect expression (IDENTICAL_BRANCHES)
/plugins/extensions/pykrita/sip/krita/sipkritapart0.cpp: 16310 in meth_SelectionMask_type(_object *, _object *)()
16304 #line 26 "/usr/share/sip/PyQt5/QtCore/qmetaobject.sip"
16305 #include <qmetaobject.h>
16306 #line 16542 "/home/boud/dev/b-krita/plugins/extensions/pykrita/sip/./krita/sipkritapart0.cpp"
16307 #line 26 "/usr/share/sip/PyQt5/QtCore/qcoreevent.sip"
16308 #include <qcoreevent.h>
16309 #line 16545 "/home/boud/dev/b-krita/plugins/extensions/pykrita/sip/./krita/sipkritapart0.cpp"
>>> CID 253685: Incorrect expression (IDENTICAL_BRANCHES)
>>> Ternary expression on condition "sipSelfWasArg" has identical then and else expressions: "QString(sipCpp->SelectionMask::type())". Should one of the expressions be modified, or the entire ternary expression replaced?
16310 #line 247 "/usr/share/sip/PyQt5/QtCore/qcoreevent.sip"
16311 #include <qcoreevent.h>
16312 #line 16548 "/home/boud/dev/b-krita/plugins/extensions/pykrita/sip/./krita/sipkritapart0.cpp"
16313 #line 235 "/usr/share/sip/PyQt5/QtCore/qcoreevent.sip"
16314 #include <qcoreevent.h>
16315 #line 16551 "/home/boud/dev/b-krita/plugins/extensions/pykrita/sip/./krita/sipkritapart0.cpp"
** CID 253684: API usage errors (ALLOC_FREE_MISMATCH)
/home/boud/dev/krita/plugins/impex/xcf/kis_xcf_import.cpp: 311 in KisXCFImport::convert(KisDocument *, QIODevice *, KisPinnedSharedPtr<KisPropertiesConfiguration>)()
________________________________________________________________________________________________________
*** CID 253684: API usage errors (ALLOC_FREE_MISMATCH)
/home/boud/dev/krita/plugins/impex/xcf/kis_xcf_import.cpp: 311 in KisXCFImport::convert(KisDocument *, QIODevice *, KisPinnedSharedPtr<KisPropertiesConfiguration>)()
305 do {
306 it->rawData()[0] = GET_ALPHA(*data);
307 ++data;
308 } while (it->nextPixel());
309 it->nextRow();
310 }
>>> CID 253684: API usage errors (ALLOC_FREE_MISMATCH)
>>> Calling "operator delete" frees "tile" using "operator delete" but it should have been freed using "free".
311 delete tile;
312 }
313 }
314 mask->paintDevice()->setX(left);
315 mask->paintDevice()->setY(top);
316 }
** CID 253683: Null pointer dereferences (FORWARD_NULL)
________________________________________________________________________________________________________
*** CID 253683: Null pointer dereferences (FORWARD_NULL)
/home/boud/dev/krita/plugins/impex/xcf/3rdparty/xcftools/flatten.c: 491 in flattenTopdown()
485 unsigned nlayers, const struct rect *where)
486 {
487 struct Tile *tile = 0;
488
489 while( nlayers-- ) {
490 if( tileSummary(top) & TILESUMMARY_ALLFULL ) {
>>> CID 253683: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "tile" to "freeTile", which dereferences it.
491 freeTile(tile);
492 return top ;
493 }
494 if( !spec->layers[nlayers].isVisible )
495 continue ;
496
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbsBCcQH3Atmwb4TYT-2FqANQ2J3wlSOCm-2B3ylNE5FNMH0Q-3D-3D_H2sGkMRRC1DUE-2Bievv2oNsjuK-2BXMiz8ix5dOOV7MqeWU50zmgeUxgmva8JPQMso2fCxbtZyMJUGPjTE2eUPBJhRBJcJ9KFV2-2FyXqK6A-2BkKWo6Y2rybCOJeQJEMSSDTMmB24EOPwEUj-2B-2Bw14kKgIzDIep6f7PmkOviGk0LMsLwbQKYllrvVKfjnw-2BOVvrE6NUmbj6qKYywS0bR5jLhifcfA-3D-3D
More information about the kimageshop
mailing list