New Defects reported by Coverity Scan for krita

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to krita found with Coverity Scan.

2 new defect(s) introduced to krita found with Coverity Scan.
26 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 250776:  Uninitialized members  (UNINIT_CTOR)
/home/boud/dev/krita/libs/widgets/KisVisualTriangleSelectorShape.cpp: 54 in KisVisualTriangleSelectorShape::KisVisualTriangleSelectorShape(QWidget *, KisVisualColorSelectorShape::Dimensions, const KoColorSpace *, int, int, const KoColorDisplayRendererInterface *, int)()


________________________________________________________________________________________________________
*** CID 250776:  Uninitialized members  (UNINIT_CTOR)
/home/boud/dev/krita/libs/widgets/KisVisualTriangleSelectorShape.cpp: 54 in KisVisualTriangleSelectorShape::KisVisualTriangleSelectorShape(QWidget *, KisVisualColorSelectorShape::Dimensions, const KoColorSpace *, int, int, const KoColorDisplayRendererInterface *, int)()
48                                                                      int barwidth)
49         : KisVisualColorSelectorShape(parent, dimension, cs, channel1, channel2, displayRenderer)
50     {
51         //qDebug() << "creating KisVisualTriangleSelectorShape" << this;
52         m_barWidth = barwidth;
53         setTriangle();
>>>     CID 250776:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_type" is not initialized in this constructor nor in any functions that it calls.
54     }
55     
56     KisVisualTriangleSelectorShape::~KisVisualTriangleSelectorShape()
57     {
58         //qDebug() << "deleting KisVisualTriangleSelectorShape" << this;
59     }

** CID 250775:  Incorrect expression  (UNINTENDED_INTEGER_DIVISION)
/home/boud/dev/krita/libs/widgets/KisVisualEllipticalSelectorShape.cpp: 145 in KisVisualEllipticalSelectorShape::convertWidgetCoordinateToShapeCoordinate(QPoint) const()


________________________________________________________________________________________________________
*** CID 250775:  Incorrect expression  (UNINTENDED_INTEGER_DIVISION)
/home/boud/dev/krita/libs/widgets/KisVisualEllipticalSelectorShape.cpp: 145 in KisVisualEllipticalSelectorShape::convertWidgetCoordinateToShapeCoordinate(QPoint) const()
139     {
140         //default implementation:
141         qreal x = 0.5;
142         qreal y = 1.0;
143         qreal offset = 7.0;
144         QPointF center = QRectF(QPointF(0.0, 0.0), this->size()).center();
>>>     CID 250775:  Incorrect expression  (UNINTENDED_INTEGER_DIVISION)
>>>     Dividing integer expressions "this->width()" and "2", and then converting the integer quotient to type "double". Any remainder, or fractional part of the quotient, is ignored.
145         qreal a = (this->width()/2);
146         qreal xRel = center.x()-coordinate.x();
147         qreal yRel = center.y()-coordinate.y();
148         qreal radius = sqrt(xRel*xRel+yRel*yRel);
149     
150         if (m_type!=KisVisualEllipticalSelectorShape::borderMirrored){


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbsBCcQH3Atmwb4TYT-2FqANQ2J3wlSOCm-2B3ylNE5FNMH0Q-3D-3D_H2sGkMRRC1DUE-2Bievv2oNsjuK-2BXMiz8ix5dOOV7MqeUU4kI27g1t8Ajqo37oMKMBU2qrUujQoRVTQlz4BvVmac9nz1d-2FAoOgkXvHDyWUMU8ySUUaiXsbairSuwkWa9eSw0QxTHA86gN2jmckjGgCo-2Fqw8tsM2v6KIXcDs0jq0u86bw-2BzWb13zZH7R56aKYJRDkzP02KwsXz8egvsHMyYJg-3D-3D